Use python 3.12 for ci controlled scripts - #1055
Conversation
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
I think we should open a test PR against pulpcore to check that this works first. It looks fine, but I wonder if installing dependencies per script run will expose that we have been relying on global dependencies installed from previous steps.
| {%- endif %} | ||
|
|
||
| {{ install_python_deps(["build", "towncrier", "twine", "wheel", "httpie", "docker", "netaddr", "boto3", "ansible~=10.3.0", "mkdocs", "jq", "jsonpatch", "bump-my-version"]) | indent(6) }} | ||
| {{ install_python_deps(["httpie", "docker", "netaddr", "boto3", "ansible~=10.3.0", "mkdocs", "jsonpatch"]) | indent(6) }} |
There was a problem hiding this comment.
Is this now the last invocation of install_python_deps?
There was a problem hiding this comment.
I don't know. I didn't make the uv change complete in all places. Kind of reducing the risk here.
| run: | | ||
| echo "Need to debug? Please check: https://github.com/marketplace/actions/debugging-with-tmate" | ||
| http --timeout 30 --check-status --pretty format --print hb "https://pulp${PULP_API_ROOT}api/v3/status/" || true | ||
| pulp status || true |
There was a problem hiding this comment.
I don't think it's guaranteed that the cli will be installed. Also, why is this changing now? I don't see the change for display_logs macro?
There was a problem hiding this comment.
Well, it is for a long time now. And this workflow file was just outdated compared to the templates.
(Apparently not everybody adjusting the templates brings the changes to these bootstrap files too.)
I did try it on this PR: |
|
Let's add pulp/pulpcore#8109 for the test. |
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
Pulpcore passes, so looks good to me. Thanks!
2 participants
📜 Checklist
See: Pull Request Walkthrough