Skip to content

Add RPM repository and remote pages to Match DEB and FILE - #370

Open
Nparente27 wants to merge 12 commits into
pulp:mainfrom
Nparente27:rpm-repo-pages
Open

Nparente27 wants to merge 12 commits into
pulp:mainfrom
Nparente27:rpm-repo-pages

Conversation

@Nparente27

@Nparente27 Nparente27 commented Oct 4, 2026 •

Copy link
Copy Markdown

Updated PulpUI to include more functionality for RPMs. I tried to match as much as I could the functionality of DEB and FILE packages. There's a line: const PLUGINS_WITH_POLICY = ['rpm']; that I only included RPM on because DEB and FILE are outside the scope of the PR, but this can be easily added in another branch.

This was developed with assistance of an AI, specifically Claude. The scope, design, and testing was human-reviewed and tested using a local Pulp instance.

@Nparente27 Nparente27 changed the title Rpm repo pages Add RPM repository and remote pages to Match DEB and FILE Oct 4, 2026
@Redtigercod4

Copy link
Copy Markdown
Contributor

Hi @Nparente27, thanks for this! We merged a stricter CI pipeline after you opened the PR, so I'm closing and reopening it to run your changes against the new checks.

You don't need to do anything yet. If anything fails that isn't caused by your changes, I'll sort it out separately. If something does come from this PR, I'll point it out and help.

@Redtigercod4 Redtigercod4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I've been through the PR and left comments inline. Please take a look at them and let me know if you need anything more from me.

I would recommend going through and seeing if there are any files that can be made generic and reused instead of duplicating them.

)}
{plugin !== 'rpm' &&
formGroup(
// putting the plugin check here because private repositories

@Redtigercod4 Redtigercod4 Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOULD: Not blocking but could we tidy up this comment?

It says Ansible is the only plugin that needs private, but the condition is plugin !== rpm, so FILE and DEB still get the checkbox. The comment and the code don't agree.

Suggested change
// putting the plugin check here because private repositories
// NOTE: 'private' is a pulp_ansible field. It is not a concept in RPM repositories.
// TODO(#GH_ISSUE_NO): confirm whether FILE and DEB repositories support it, and if not limit this to ansible.

),
},
{
label: t`Autopublish`,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUST: autopublish is listed twice here, so it shows up twice on the details tab.

Comment thread src/actions/index.ts
export { fileRepositoryDeleteAction } from './file-repository-delete';
export { fileRepositoryEditAction } from './file-repository-edit';
export { fileRepositorySyncAction } from './file-repository-sync';
export { rpmRemoteCreateAction } from './rpm-remote-create';

@Redtigercod4 Redtigercod4 Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COULD: Please don't re-export the RPM actions from this barrel instead please import them from their own modules in the containers.

Re-exporting here pulls the new actions into a new 3 cyclic dependency tree and will cause future issues building the application.

Comment thread src/api/index.ts
export { RoleAPI } from './role';
export { RPMPackageAPI } from './rpm-package';
export { RPMRepositoryAPI } from './rpm-repository';
export { RPMDistributionAPI } from './rpm-distribution';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actionContext: object;
}

const MaybeCode = ({ code, filename }: { code: string; filename: string }) =>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD: MaybeCode is an identical copy of the one in file-remote/tab-details.tsx and two other places. Could we move it into a shared location so that it can be reused across the other implementations?

Comment thread src/containers/index.ts
export { default as EditRole } from './role-management/role-edit';
export { default as RoleList } from './role-management/role-list';
export { default as RPMPackageList } from './rpm/package-list';
export { default as RPMRemoteDetail } from './rpm-remote/detail';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ name, pulp_href, pulpId },
{ addAlert, setState, listQuery },
) {
const distributionsToDelete = await listDistributions(pulp_href).catch(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD: If listing the distributions fails, the repository is still deleted, and the repository and distribution deleted run concurrently. Could we abort when the lookup fails, and delete the distributions first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request legacy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants