Skip to content

Type classes: Omit explicit instance name#417

Open
gasi wants to merge 1 commit into
purescript:masterfrom
gasi:patch-1
Open

Type classes: Omit explicit instance name#417
gasi wants to merge 1 commit into
purescript:masterfrom
gasi:patch-1

Conversation

@gasi

@gasi gasi commented Feb 14, 2022

Copy link
Copy Markdown

The compiler change to make instance names optional was introduced in v0.14.2:
https://github.com/purescript/purescript/releases/tag/v0.14.2

The compiler change to make instance names optional was introduced in v0.14.2:
https://github.com/purescript/purescript/releases/tag/v0.14.2

@JordanMartinez JordanMartinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I'm wondering if we should state that instance names are optional and provide an example.

AFAIK, removing instance names altogether hasn't been discussed and they're still used in core/contrib/web/node libraries. A new user might wonder if they are some advanced syntax or something.

@thomashoneyman

thomashoneyman commented Feb 14, 2022

Copy link
Copy Markdown
Member

Yea, these instances are preserved across core / contrib until 0.15 because it’s a breaking change to remove them (it means losing support for 0.14.0 and 0.14.1). I think it’d be preferable to mention they’re optional.

I believe there’s another docs page where we talk about instance names being used for readable JavaScript that we could crib from?

@JordanMartinez

Copy link
Copy Markdown
Contributor

This hasn't been merged because feedback hasn't been addressed. It wouldn't take much to finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants