Skip to content

docs: use a requests version that exists in the pyproject.toml tutorial - #827

Merged
agriyakhetarpal merged 1 commit into
pyOpenSci:mainfrom
simonvanlierde:fix-requests-version
Oct 16, 2026
Merged

agriyakhetarpal merged 1 commit into
pyOpenSci:mainfrom
simonvanlierde:fix-requests-version

Conversation

@simonvanlierde

Copy link
Copy Markdown
Contributor

Hi!

The pyproject.toml tutorial pins "requests==10.1" in its dependency examples, but requests has no 10.x release (the latest is 2.34.2). A reader who copies the final pyproject.toml and runs pip install -e . gets "No matching distribution found for requests==10.1".

  • I changed the pin to requests==2.32.3, a real release, in all six places on the page: the specifier example and the five full pyproject.toml examples.
  • In the specifier example I moved the comments over by two spaces, so they still line up with the longer version string.

Tests: nox -s docs-test passes locally, and so do the translated builds. The .po files don't contain the pin, so I didn't touch them.

Best,

Simon

@netlify

netlify Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for python-package-guide ready!

Name Link
🔨 Latest commit efe732f
🔍 Latest deploy log https://app.netlify.com/projects/python-package-guide/deploys/6acf7819c682555dba394558
😎 Deploy Preview https://deploy-preview-827--python-package-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@agriyakhetarpal agriyakhetarpal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @simonvanlierde, this makes sense! Thank you!

@agriyakhetarpal
agriyakhetarpal merged commit 31bcf20 into pyOpenSci:main Oct 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants