Skip to content

Fixed #133 forwarding user target_compatible_with flags #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikael-s-persson wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

Fixed #133 forwarding user target_compatible_with flags #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions build_defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ def pybind_extension(
# Mark common dependencies as required for build_cleaner.
tags = tags + ["req_dep=%s" % dep for dep in PYBIND_DEPS]

arg_target_compatible_with = kwargs.pop("target_compatible_with", [])

cc_binary(
name = name + ".so",
copts = copts + PYBIND_COPTS + select({
Expand All @@ -149,7 +151,7 @@ def pybind_extension(
}),
linkshared = 1,
tags = tags,
target_compatible_with = select({
target_compatible_with = arg_target_compatible_with + select({
"@platforms//os:windows": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
Expand All @@ -171,7 +173,7 @@ def pybind_extension(
}),
linkshared = 1,
tags = tags,
target_compatible_with = select({
target_compatible_with = arg_target_compatible_with + select({
"@platforms//os:windows": [],
"//conditions:default": ["@platforms//:incompatible"],
}),
Expand Down
Loading