Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinearConstraint.combine()documents its argument as an iterable of constraints, but indexes it before iterating over it repeatedly. Passing a list iterator or generator raisesTypeErrorinstead of combining the constraints. An empty iterator also bypasses the existing empty-input check.Materialize the iterable once before validation. This preserves the existing coefficient/constant stacking and variable-name checks while accepting single-pass inputs. The regression test checks list iterators and generator expressions against explicit expected coefficient and constant matrices, and checks the existing ValueError messages for empty and incompatible inputs.
Validation: the new regression fails before the fix while the existing combine test passes (1 failed, 1 passed). After the fix the complete suite passes (163 passed). Project-pinned Ruff 0.17.1 format --check and git diff --check pass. Tested with Python 3.12.14, NumPy 2.5.4, pandas 2.3.3, SciPy 1.18.1 and pytest 9.1.1. No statistical computation is changed.