Repository navigation
Conversation
When writing with consolidated=True to a store that addresses a node below the root of the underlying store (e.g. zarr.storage.StorePath(store, "grp")), also consolidate metadata at that node. Reading the same store looks for consolidated metadata there; before, it only existed at the store root, so reading fell back to non-consolidated metadata with a RuntimeWarning, or raised with consolidated=True. Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Writing with
consolidated=Trueto a store that addresses a node below the store root, such aszarr.storage.StorePath(store, "grp"), only consolidated metadata at the store root. Reading the same store back looks for consolidated metadata atgrp, so it fell back to non-consolidated metadata with aRuntimeWarning, or raised aValueErrorwithconsolidated=True. This happens with both zarr formats 2 and 3.Now xarray also consolidates at the node the store addresses: the group's path, minus any
group=. It still consolidates at the store root as before, so reading withopen_zarr(store, group="grp")keeps working.Checklist
whats-new.rstAI Disclosure
Tools: Claude Code
[This is Claude Code on behalf of Joe Hamman]
🤖 Generated with Claude Code