Repository navigation
release.py: fix conda/PyPI name matching; propose next-minor caps - #567
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 29 29
Lines 2033 2033
=======================================
Hits 1981 1981
Misses 52 52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
.ci_support/release.py, whichdeploy.ymlruns to turn the==pins inpyproject.tomlinto published ranges. It makes two bug fixes and one policy proposal, and they can be split if you'd rather take only the fixes.1. Bug fix: name matching in
get_env_versionl.replace("-", "")was meant to strip the YAML list marker, but it removes every hyphen. Somatplotlib-basebecomesmatplotlibbaseandscikit-learnbecomesscikitlearn. Neither matches its name inpyproject.toml, so both fall through to an exact==pin. Released 0.0.48 shows the effect, in the optional extras:scikit-learn==1.9.1; extra == "clusters"matplotlib==3.11.2; extra == "matplotlib"The fix strips only the
"- "marker and mapsmatplotlib-base→matplotlib. A simulated deploy (environment-old.ymlplus this script) then givesmatplotlib>=3.8.0,<3.12.0andscikit-learn>=1.2.1,<1.10.0.2. Defensive fix: strip each list entry
Each entry parsed from a pin line is now
.strip()ped. Without that, a pin written as the last item of a multi-line list (no trailing comma) keeps its newline, never matches, and stays exact. This doesn't currently affect structuretoolkit'spyproject.toml, but it is the bug behindmatplotlib==3.11.1; extra == "plot"in vaspparser 0.0.12, which uses the same script.3. Policy proposal: cap at the next minor instead of
<=pinToday a dependency with a lower version in
environment-old.ymlis published as>=old,<=pin. For example, 0.0.48 hasnumpy<=2.5.3, so every new patch release of numpy needs a new structuretoolkit release before the two can be installed together.This PR caps at the next minor instead,
<X.(Y+1).0(e.g.numpy>=1.23.5,<2.6.0). A version whose minor part isn't an integer keeps<=pin. Pins with no older version inenvironment-old.ymlstay exact as before.For context: this is a policy choice, not a correction. The shared pyiron/actions release workflow defaults to
semantic-upper-bound: 'patch', which is in the same spirit as<=pin. pyiron_workflow, semantikon and pyiron_workflow_atomistics opt into'minor', and this proposes the same for structuretoolkit. Happy to drop this part and keep only the fixes above.🤖 Generated with Claude Code