Repository navigation
Replace deprecated typing.AnyStr with a constrained TypeVar in util.change_root - #409
Merged
Merged
Conversation
…hange_root typing.AnyStr is deprecated (PEP 695 era) and slated for removal. Use an explicit TypeVar constrained to (str, bytes) to preserve the same typing behavior for change_root. Originally proposed by @sobolevn in pypa/setuptools#5232, where distutils is vendored; making the change here so it persists through the next sync. Co-Authored-By: sobolevn <46602750+sobolevn@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2 tasks
Contributor
|
In #392 I disable static tests failing on setuptools code that distutils has no weight / effect upon. Which should resolve your failing tests here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typing.AnyStris deprecated and slated for removal, so this replaces its use inutil.change_rootwith an explicitTypeVar("_StrBytes", str, bytes)— preserving the same type-checking behavior (bound betweenstrandbytes).This originated as @sobolevn's pypa/setuptools#5232. Since
setuptools/_distutilsis vendored from here and overwritten on each sync, theutil.pyportion of that PR was routed upstream to this repo so it persists; the setuptools-owned parts (glob.py,bdist_egg.py) were merged there.🤖 Generated with Claude Code