Repository navigation
Infer NumPy Generator.uniform and exponential result shapes - #5651
Open
AlessandroRuggiero wants to merge 1 commit into
Open
AlessandroRuggiero wants to merge 1 commit into
AlessandroRuggiero wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same pattern as #5619:
rng.uniformandrng.exponentialnow returnsize's shape, or withoutsizethe broadcast shape of arraylow/high(scale's shape forexponential).test_issue_4917.pycallsrng.uniformwith a tuple size, so it now gets exact shapes instead ofAny; I updated its expectations. It no longer exercises comparing an unknown-shape array with a float.Test Plan
Added tests to
tensor-shapes/pyrefly-numpy-stubs/test/test_random.pycovering int, tuple, list and symbolicsize, array parameters with and withoutsize, mismatchedlow/high, and thefloatresult without arrays orsize. Updated the expectations intest_issue_4917.py.Ran:
python3 tensor-shapes/pyrefly-numpy-stubs/run_pyrefly.py"$TENSOR_SHAPES_VENV/bin/python" tensor-shapes/pyrefly-numpy-stubs/run_runtime_tests.py./test.py --no-test --no-tensor-shapes --no-conformance --no-jsonschema --no-extension(formatting and lint)