Skip to content

🧪 test: run template tests without symlink privileges - #283

Merged
gaborbernat merged 4 commits into
pytest-dev:mainfrom
zombieli:test/copy-template-without-symlinks
Oct 27, 2026
Merged

gaborbernat merged 4 commits into
pytest-dev:mainfrom
zombieli:test/copy-template-without-symlinks

Conversation

@zombieli

@zombieli zombieli commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Contributors on Windows without permission to create symbolic links, which os.symlink needs there, could not run the suite: 65 environment-loading and verbose-output tests failed with WinError 1314 before reaching the plugin. 🪟 With this change the suite runs on such accounts too.

Each generated pytester project now gets a small entry module that executes the shared env-checking template from its original location, where a symlink used to point at it. Running the original file keeps coverage attributed to the template, which a plain copy would lose. The plugin is unchanged, so the PR carries no release note.

@zombieli
zombieli requested a review from gaborbernat as a code owner October 25, 2026 05:24
zombieli and others added 2 commits October 25, 2026 13:24
The PR changes only the test suite, so it has no user-facing release note;
CONTRIBUTING.md asks for the `skip news` label instead of a fragment. Type the
template path Final like the other locals in the test modules.
@gaborbernat gaborbernat changed the title Run template-based tests without requiring symlink privileges 🧪 test: run template tests without symlink privileges Oct 27, 2026
@gaborbernat gaborbernat added the skip news PR does not need a changelog entry label Oct 27, 2026
Pytest injects fixtures and parameters as arguments, so test signatures
grow past the argument limits. Ignore the two rules for tests in the config
and drop the inline suppressions.
@gaborbernat
gaborbernat merged commit d1c1f5f into pytest-dev:main Oct 27, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news PR does not need a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants