fix: allow int values for timeout ini options with pytest 9.0 (#194)#198
Closed
fazalpsinfo-cmyk wants to merge 1 commit into
Closed
fix: allow int values for timeout ini options with pytest 9.0 (#194)#198fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
pytest 9.0 changed the default addini type from None to 'string', so int values like 'timeout = 1200' in pyproject.toml now raise TypeError before the plugin can convert them. Explicitly setting type=None restores the pytest 8.x behavior and lets _validate_timeout handle both int and string inputs (as it already does via float(timeout)). Fixes pytest-dev#194
Member
|
This changes nothing at all about the issue reported in #194. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Int timeout values rejected by pytest 9.0
pytest 9.0 changed the default
addini(type=...)fromNoneto'string', so int values liketimeout = 1200inpyproject.tomlnow raise
TypeErrorbefore the plugin can convert them.Explicitly setting
type=Noneon thetimeoutandsession_timeoutini options restores the pytest 8.x behavior and lets
_validate_timeouthandle both int and string inputs.Note: 46/55 tests fail pre-existing (pytest version incompatibility
with the test suite). My change introduces 0 new failures.
Fixes #194
Support my work: https://buymeacoffee.com/muhamedfazalps