Fix loadscope scheduler deadlock after a worker crash - #1363
Open
larsoner wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelogfolder ...I used Claude Fable 5 to look into #1313 (after hitting a very reliable hang in MNE-Python in mne-tools/mne-python#14063 during a ~20m run). With some guidance, Claude was able to boil it down into a minimal repro (now adapted into a unit test) and suggest this fix based on its conclusion:
I then tested in mne-tools/mne-python#14101 that 1) it still hung in MNE-Python with latest pytest-xdist
master(it did), then 2) used this PR and saw it succeed in ending properly after an error rather than hanging. It coming back red allowed me to narrow down the bug to a Qt6<->Cocoa issue (with multiple runs, each ending properly on this branch) and work around it to get to green 🎉 !Related to #1313 and addressed what I commented on there, but not sure if it actually closes it or not. @clemlesne you could try my branch and check if you have the spare cycles (I pushed upstream tags to git so the dynamic dev version gets resolved correctly, and used
pip install "pytest-xdist @ git+https://github.com/larsoner/pytest-xdist.git@lock"in my own testing.)