Conversation
The testsfailed check lived in pytest_runtestloop, so a plugin that replaced that hook skipped the abort. Move it to the default pytest_collection implementation. Fixes pytest-dev#15028
psf-chronographer
Bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15028.
The collection-error abort lives in the default
pytest_runtestloop. That hook isfirstresult, so a plugin that implements it never hits the check and will run tests (or do something else) after collection failed.Move the
testsfailedcheck into the defaultpytest_collection.--continue-on-collection-errorsis unchanged.--collect-onlystill aborts, because the raise now happens beforepytest_runtestloopreturns early.This is a documented behaviour change for plugins that replace
pytest_collectionentirely. @bluetech said that's the right place for the check and to treat it as deferred to the next major.