fix tmp_path retention for setup and teardown errors - #15078
Open
qinpei-dev wants to merge 1 commit into
Open
qinpei-dev wants to merge 1 commit into
qinpei-dev wants to merge 1 commit into
Conversation
Author
|
The only failing required check is the PyPy xdist job. The failure occurs in: with: I investigated the failure and it appears unrelated to this PR. This change only modifies tmp_path retention behavior in All tmp_path-related tests and the main build matrix are passing. I will leave the unrelated PyPy failure unchanged unless maintainers prefer otherwise. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tmp_path_retention_policy = "failed" currently removes temporary directories when failures occur during setup or teardown.
Cleanup previously happened before the teardown report was available.
This change defers the cleanup decision until teardown reporting and retains directories when setup, call, or teardown failed.
Regression coverage includes setup error, call failure, teardown error, skip, and pass.
Fixes #14998