Fix missing macOS wheels for regular Python 3.14+ - #318
Merged
Conversation
Co-installing the regular and free-threaded interpreters in the same setup-python step and relying on `maturin build --find-interpreter` causes the free-threaded interpreter to shadow the regular one on PATH on macOS (both install a `python3.14` binary), so no regular cp314 wheel gets built. This is the same class of issue already fixed for Windows in ec5eca2; apply the same separate-steps fix to the macos job. Fixes #317. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The requested macOS build separation is implemented and no unresolved issues remain.
Pull request overview
Fixes missing regular macOS Python 3.14+ wheels by separating regular and free-threaded interpreter builds.
Changes:
- Builds regular macOS wheels explicitly.
- Builds free-threaded wheels separately.
- Documents the fix in the changelog.
File summaries
| File | Summary |
|---|---|
CHANGELOG.rst |
Documents the macOS wheel fix. |
.github/workflows/release.yml |
Separates regular and free-threaded macOS wheel builds. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
seddonym
marked this pull request as ready for review
September 11, 2026 10:28
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-installing the regular and free-threaded interpreters in the same setup-python step and relying on
maturin build --find-interpretercauses the free-threaded interpreter to shadow the regular one on PATH on macOS (both install apython3.14binary), so no regular cp314 wheel gets built. This is the same class of issue already fixed for Windows in ec5eca2; apply the same separate-steps fix to the macos job.Fixes #317.