Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wheels don't include the libbrotli license. There's also a note from 2015 that libbrotli is apache 2.0 but libbrotli changed to MIT about a month after the note was written. I fixed both.
The sdist doesn't include the tox.ini or test fixtures so the tests can't ben run from the sdist. The only reason the tests work is the tests use
git checkout. I switched the tests to download and build the sdist without a git checkout and added the test files that are currently excluded. I had to hand-exclude some test data to avoid unnecessarily including large data files in the sdist.