Repository navigation
test: cover informational response status 199 - #212
Open
renanmpimentel wants to merge 1 commit into
Open
renanmpimentel wants to merge 1 commit into
renanmpimentel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this test matters
Changing the exclusive upper comparison by one would reject status 199 even though
[100, 200)includes it. The new event-construction test catches that protocol-boundary regression.Supertest audit method
I used the Supertest test-audit skill to probe whether the existing suite would catch a plausible violation of this contract. The regression was applied only in an isolated worktree. The regression proof records three executed states: the existing tests pass with that regression, the new assertion fails against the same regression, and the new test passes with the original production code restored. The published diff adds tests only.
Change and verification
Adds a regression case for the upper boundary of
InformationalResponse's documented[100, 200)status range. Status199must be accepted.Regression proof: changing the upper comparison to
< 199leaves all 78 existing tests passing, but makes the new case fail withLocalProtocolError. With production code restored, 79 tests pass. Black, isort, mypy, compileall, andgit diff --checkalso pass.This PR changes tests only.
Repository guidance
CONTRIBUTING.mdwelcomes coverage improvements, requests Black/isort and passing tests, and suggeststox. The recorded checks ran pytest and the format/type tools directly;toxwas not run locally.