Repository navigation
reject unparseable authority when host/port/password checks are set - #165
Open
Bountybette wants to merge 1 commit into
Open
Bountybette wants to merge 1 commit into
Bountybette wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the authority can't be parsed,
uri.host,uri.portanduri.userinfoall return None, andValidator.validatetreats None as "component absent", soValidator().allow_hosts("good.com").validate(uri_reference("https://user@user@evil.com/"))passes even thoughurllib.parse.urlsplitand requests send that URL toevil.com(the same gap skipsallow_portsandforbid_use_of_password).validatenow raisesInvalidComponentsErrorfor an unparseable authority whenever one of those checks is configured, so validators that only check the scheme or path behave exactly as before.