Repository navigation
Fix ParseResultBytes.authority for references without an authority - #166
Open
mayuriphad wants to merge 1 commit into
Open
mayuriphad wants to merge 1 commit into
mayuriphad wants to merge 1 commit into
Conversation
ParseResultBytes.authority called encode() on None, so unsplit() and copy_with() raised AttributeError for any reference with no authority, while ParseResult returned None. Return None in that case. Fixes python-hyper#163. Signed-off-by: mayuriphad <mayuriphad656@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163.
ParseResultBytes.authoritycalledencode()onself.reference.authoritywithout aNonecheck. For any reference without an authority (/a,a,mailto:x,?q)unsplit()andcopy_with()raisedAttributeError, whileParseResulthandles the same input and returnsNone.The property now returns
Nonewhen the reference has no authority, and its return type isOptional[bytes], matchingParseResult.authority.Test:
test_unsplit_reference_without_authorityround-trips five such references through both classes. Three of its cases fail without the change and all pass with it. The rest of the suite is unchanged. I also added a line tounreleased.rst.