Fix test_snippets_completion to not depend on typeshed overload ordering#709
Merged
Merged
Conversation
jedi 0.20.0 bundles a newer typeshed that adds a no-arg overload for defaultdict.__init__ as the first overload, causing format_snippet to hit the zero-params branch and produce "defaultdict()" instead of "defaultdict($0)". Replace defaultdict with a locally-defined function to make the test stable across typeshed updates.
ccordoba12
changed the title
test_snippets_completion to not depend on typeshed overload ordering
ccordoba12
approved these changes
Jul 18, 2026
ccordoba12
left a comment
ccordoba12
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution @frenzymadness!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jedi 0.20.0 bundles a newer typeshed that adds a no-arg overload for defaultdict.init as the first overload, causing format_snippet to hit the zero-params branch and produce "defaultdict()" instead of "defaultdict($0)". Replace defaultdict with a locally-defined function to make the test stable across typeshed updates.