Skip to content

Reject path-like locale names in Locale.load #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sharadhi-v98 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Reject path-like locale names in Locale.load #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/pendulum/locales/locale.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ def load(cls, locale: str | Locale) -> Locale:
if locale in cls._cache:
return cls._cache[locale]

# A locale is a package name, not a path
if not re.fullmatch("[a-z]+(_[a-z0-9]+)*", locale):
raise ValueError(f"Locale [{locale}] does not exist.")

# Checking locale existence
actual_locale = locale
locale_path = cast(Path, resources.files(__package__).joinpath(actual_locale))
Expand Down
6 changes: 6 additions & 0 deletions tests/test_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,12 @@ def test_set_locale_malformed_locale(locale: str) -> None:
pendulum.set_locale("en")


@pytest.mark.parametrize("locale", ["..", "../tz", "en/../en"])
def test_set_locale_path_is_invalid(locale: str) -> None:
with pytest.raises(ValueError):
pendulum.set_locale(locale)


def test_week_starts_at() -> None:
pendulum.week_starts_at(pendulum.SATURDAY)

Expand Down