Repository navigation
Allow arithmetic between two IFDRational instances - #10321
Merged
radarhere merged 2 commits intoOct 27, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
|
Hi. Does this relate to a bug that you experienced, would like fixed and will help you? Or is this just AI finding and fixing a bug by itself? |
radarhere
reviewed
Oct 27, 2026
radarhere
reviewed
Oct 27, 2026
radarhere
enabled auto-merge (squash)
October 27, 2026 08:23
radarhere
approved these changes
Oct 27, 2026
radarhere
force-pushed
the
fix/ifdrational-arithmetic
branch
3 times, most recently
from
October 27, 2026 10:35
a3377b5 to
065ca69
Compare
radarhere
force-pushed
the
fix/ifdrational-arithmetic
branch
from
October 27, 2026 10:45
065ca69 to
c8798b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
IFDRational(1, 2) + IFDRational(1, 3)(and-,*,/,//,%) raisedTypeError:FractionreturnsNotImplementedfor the wrapper, and Python does not try the reflected method when both operands have the same type. This affects arithmetic on EXIF values such as GPS degrees/minutes/seconds.NotImplementedand the other operand is anIFDRational, retry with its underlying value. Other comparisons (e.g. the signedness check for nan values) are unchanged.