Use bytearray instead of BytesIO in MspDecoder - #9877
Open
radarhere wants to merge 2 commits into
Open
Conversation
akx
approved these changes
Aug 31, 2026
akx
left a comment
Contributor
There was a problem hiding this comment.
LGTM. bytearray and BytesIO seem to use the exact same mechanism for figuring out how much to grow the backing array with, so that's not making a difference here.
Not that I imagine Windows 1 and 2 Paint images to generally be very large 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When iterating through rows, the row index is assigned to
xPillow/src/PIL/MspImagePlugin.py
Line 129 in 3220aca
ywould seem to be the correct choice instead.MspDecoderwrites to aio.BytesIOinstance, only to retrieve the value from it once done. Usingbytearray()would be simpler.