Escape backslashes when drawing PostScript text - #9996
Open
lllleolin-max wants to merge 1 commit into
Open
Conversation
Member
|
Hmm.
I wonder if it might be better to leave the current behaviour as it is, and instead add a new What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PSDraw.text()escapes parentheses but leaves backslashes unchanged. Text such asC:\temp\newis therefore interpreted as containing PostScript escape sequences, while a trailing backslash escapes the closing delimiter and produces an unfinished string.Changes proposed in this pull request:
Validation:
main,Tests/test_psdraw.py: 5 failed, 5 passed. After the fix,Tests/test_psdraw.pyandTests/test_pdfparser.py: 18 passed, no skips;selftest.py: 59 passed.PdfParser: 5 of 8 cases fail before the fix, and all 8 round-trip afterwards. PDF and PostScript use the same literal-string escaping rules; this checks serialization, not rendering.Tests ran on Windows/Python 3.12.11 with the checkout's
PSDrawandPdfParsermodules and Pillow 12.3.0's prebuilt native extensions and remaining Python modules. Native extensions were not rebuilt. Ghostscript is unavailable here, so no interpreter/rendering check was run; the full test, pre-commit and Sphinx documentation suites were not run.Prepared with AI assistance.