Repository navigation
Conversation
OutOfOrderTableProxy maps each key to positions in self._tables, but
_remove_table took a table out of that list without shifting the later
positions, so a second delete through the same proxy indexed the wrong
table or ran past the end:
tool = doc["tool"]; del tool["black"]; del tool["ruff"] # IndexError
Remove the table by identity and shift the later positions down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleting two keys through the same out-of-order table proxy raises or silently does nothing:
With
[tool.a],[tool.b]and[tool.c]split by other tables,clear()returns but leaves[tool.b]and[tool.c]in the output._tables_mapholds positions inself._tables, and_remove_tableremoved the table withlist.removewithout shifting the later positions (list.removealso compares by equality, so it could take an equal empty table). It now removes the table by identity and shifts the later positions down by one.test_delete_keys_through_the_same_out_of_order_tablefails on master; dropping the shift or shifting the wrong side fails it too.pytest tests(1,069 passed) andpre-commit runon the changed files pass.Agent Drafting Metadata