Skip to content

Update AsyncFileWrapper for consistency between what we need/what we declare - #3542

Merged
A5rocks merged 4 commits into
python-trio:mainfrom
A5rocks:fileio-updates
Oct 23, 2026
Merged

A5rocks merged 4 commits into
python-trio:mainfrom
A5rocks:fileio-updates

Conversation

@A5rocks

@A5rocks A5rocks commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Inspired by #3541

I just made sure all the Can... things matched the types of the functions we define if we can do whatever it is.

@CoolCat467 CoolCat467 added the typing Adding static types to trio's interface label Oct 14, 2026
@CoolCat467

Copy link
Copy Markdown
Member

Interesting failure for pypy 3.11 ssl sockets, did pypy have an update or are tests flaky?

@A5rocks

A5rocks commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

I think PyPy had an update -- I remember PyPy 8.0.0 worked, so 8.0.1 must have broken something :/

@A5rocks
A5rocks enabled auto-merge (squash) October 23, 2026 20:44
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (c631a83) to head (1d49c2f).

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3542   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             128          128           
  Lines           19480        19480           
  Branches         1323         1323           
===============================================
  Hits            19480        19480           
Files with missing lines Coverage Δ
src/trio/_file_io.py 100.00000% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A5rocks
A5rocks merged commit 009bc2d into python-trio:main Oct 23, 2026
50 checks passed
@A5rocks
A5rocks deleted the fileio-updates branch October 23, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typing Adding static types to trio's interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants