Repository navigation
Update AsyncFileWrapper for consistency between what we need/what we declare - #3542
Merged
Merged
Conversation
CoolCat467
approved these changes
Oct 14, 2026
Member
|
Interesting failure for pypy 3.11 ssl sockets, did pypy have an update or are tests flaky? |
for more information, see https://pre-commit.ci
Contributor
Author
|
I think PyPy had an update -- I remember PyPy 8.0.0 worked, so 8.0.1 must have broken something :/ |
A5rocks
enabled auto-merge (squash)
October 23, 2026 20:44
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3542 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19480 19480
Branches 1323 1323
===============================================
Hits 19480 19480
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #3541
I just made sure all the
Can...things matched the types of the functions we define if we can do whatever it is.