Repository navigation
Tolerate PyPy's SSLError("Broken pipe") in the SSL echo server's unwrap - #3556
Merged
Merged
Conversation
The test echo server suppresses BrokenPipeError when the client has
already gone away before the server's unwrap(). PyPy's _cffi_ssl
reports that same EPIPE as a plain ssl.SSLError("Broken pipe"), so
test_send_all_empty_string flaked on PyPy.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VPZoDDtuKy1bbLLR2nsnmW
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3556 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19474 19475 +1
Branches 1323 1323
===============================================
+ Hits 19474 19475 +1
🚀 New features to boost your workflow:
|
Member
|
Could this not have been another |
Contributor
|
^ + I'm not sure this is actually addressing the root cause, I made a repro in pypy/pypy#5664 which doesn't explicitly suppress BrokenPipeError yet passes 100% of the time on CPython and PyPy 8.0.0, but fails sometimes on PyPy 8.0.1. But I mean this definitely works, all the extra work can be done in a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssl_echo_serve_syncsuppressesBrokenPipeErrorfromunwrap()when the client has already gone away, but PyPy's_cffi_sslreports that same EPIPE as a plainssl.SSLError("Broken pipe"), sotest_send_all_empty_stringflakes on PyPy (seen on #3554). This tolerates that case too; any otherSSLErrorstill propagates.