refactor(bootstrapper): apply review follow-ups to _cache module

[dhellmann]

Add docstring to Bootstrapper class describing it as an iterative DFS engine to be used as a context manager.

Rename private _cache functions that cross module boundaries to drop the leading underscore, reflecting their role as internal-but-public APIs within the bootstrapper package:

• _find_cached_wheel → find_cached_wheel
• _bg_prepare_prebuilt → bg_prepare_prebuilt

Update all call sites in _bootstrapper.py, _prepare_source.py, _resolve.py, and tests.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0a36cb98-b91d-4541-9861-d68aabd9faec

📥 Commits

Reviewing files that changed from the base of the PR and between 2495247 and 04ee072.

📒 Files selected for processing (6)

• src/fromager/bootstrapper/_bootstrapper.py
• src/fromager/bootstrapper/_cache.py
• src/fromager/bootstrapper/_prepare_source.py
• src/fromager/bootstrapper/_resolve.py
• tests/test_bootstrapper.py
• tests/test_bootstrapper_iterative.py

 ____________________________________________________________________________________________
< Founder mode code reviewer: seeing not just the bugs but the vision in every line of code! >
 --------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

📝 Walkthrough

Walkthrough

The cache helpers _find_cached_wheel and _bg_prepare_prebuilt were renamed to find_cached_wheel and bg_prepare_prebuilt. Bootstrapper, source preparation, and resolution code now use the renamed helpers. Existing tests and patch targets were updated accordingly. The Bootstrapper class also gained a docstring describing its iterative DFS behavior and context-manager flow.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title matches the main changes: bootstrapper follow-ups and _cache API renames.
Description check	✅ Passed	The description accurately summarizes the docstring addition and cross-module cache helper renames.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[rd4398]

This looks good! Thanks

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[mergify]

queue

⚠️ Configuration not compatible with a branch protection setting

Details

The branch protection setting Require branches to be up to date before merging is not compatible with draft PR checks. To keep this branch protection enabled, update your Mergify configuration to enable in-place checks: set merge_queue.max_parallel_checks: 1, set every queue rule batch_size: 1, and avoid two-step CI (make merge_conditions identical to queue_conditions). Otherwise, disable this branch protection.

[dhellmann]

@Mergifyio rebase

[mergify]

rebase

🛑 The pull request rule doesn't match anymore

Details

This action has been cancelled.