docs(bootstrapper): fix docstrings and add test for write-error logging#1258
docs(bootstrapper): fix docstrings and add test for write-error logging#1258dhellmann wants to merge 1 commit into
Conversation
- Correct `add_to_build_order` docstring: build-order data is now buffered and written once in `finalize()`, not on each call - Update `finalize()` docstring to note that background I/O errors are logged but not raised - Add comment to `__exit__` explaining pending writes are intentionally abandoned on error exit - Add "Must only be called from the main thread" note to `_write_graph_async` docstring - Add comment to `test_record_stack_state_throttled_when_called_rapidly` warning about st_mtime filesystem-resolution dependency - Add `test_check_write_error_logs_on_failure` to verify that failed background write futures are logged rather than raised Co-Authored-By: Claude <claude@anthropic.com> Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR has a few changes from Claude's review feedback on #1249
add_to_build_orderdocstring: build-order data is now buffered and written once infinalize(), not on each callfinalize()docstring to note that background I/O errors are logged but not raised__exit__explaining pending writes are intentionally abandoned on error exit_write_graph_asyncdocstringtest_record_stack_state_throttled_when_called_rapidlywarning about st_mtime filesystem-resolution dependencytest_check_write_error_logs_on_failureto verify that failed background write futures are logged rather than raised