gh-127753: make the proxies handling of urllib.request cacheable #127767
gh-127753: make the proxies handling of urllib.request cacheable #127767NewUserHa wants to merge 6 commits into
urllib.request cacheable #127767Conversation
ZeroIntensity
left a comment
There was a problem hiding this comment.
I think this needs a blurb entry.
|
actually, this structure of these functions feels no straightforward, new comers may do not know if use the original But it looks not good to change or delete the original behavior of the original |
|
Sure, if the old APIs are too broken to improve, then add something new. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
@NewUserHa hey, are you planning to get back to this PR? It still needs a news entry included. |
|
@webknjaz Thanks for your comment. I reviewed it again, and after digging deeper into the implementation, the core issue is that the However, resolving this has a few architectural dilemmas:
|
this code makes proxy_bypass_registry is also cacheable, to avoid repeating read the registry of windows.
and also makes the comment about CVE of
getproxies_environment()together and more obviouslyurllib.request#127753