Skip to content

gh-130197: Test pygettext's --version CLI option#133022

Merged
StanFromIreland merged 4 commits into
python:mainfrom
StanFromIreland:test-pyget-ver
Jun 14, 2026
Merged

gh-130197: Test pygettext's --version CLI option#133022
StanFromIreland merged 4 commits into
python:mainfrom
StanFromIreland:test-pyget-ver

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Apr 26, 2025

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 26, 2025
18 tasks

@tomasr8 tomasr8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This beyond the scope of this PR but to be honest I'm not even sure we should have a separate version for pygettext (and the --version option). It's distributed together w/ Python so the Python version itself should be enough.

@StanFromIreland

StanFromIreland commented May 13, 2025

Copy link
Copy Markdown
Member Author

Friendly ping @serhiy-storchaka

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 24, 2026

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the title is confusing.

@StanFromIreland

Copy link
Copy Markdown
Member Author

Sorry, this is a pretty old PR. Thanks for the review!

@serhiy-storchaka

Copy link
Copy Markdown
Member

And I concur with @tomasr8.

@StanFromIreland StanFromIreland changed the title gh-130197: Test option in pygettext gh-130197: Test pygettext's --version CLI option Jun 14, 2026
@StanFromIreland

Copy link
Copy Markdown
Member Author

And I concur with @tomasr8.

I do too, I opened an issue for it a long time ago, but some people objected so it never went ahead.

@StanFromIreland

Copy link
Copy Markdown
Member Author

I found it: #133319

@StanFromIreland StanFromIreland enabled auto-merge (squash) June 14, 2026 19:11
@StanFromIreland StanFromIreland merged commit d63c994 into python:main Jun 14, 2026
70 of 72 checks passed
@StanFromIreland StanFromIreland deleted the test-pyget-ver branch June 14, 2026 19:17
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO + PGO 3.x (tier-3) has failed when building commit d63c994.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1627/builds/2943) and take a look at the build logs.
  4. Check if the failure is related to this commit (d63c994) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1627/builds/2943

Summary of the results of the build (if available):

Click to see traceback logs
Note: switching to 'd63c9940f0bcc5497c42c6ac2768cdab02300e10'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at d63c9940f0bcc gh-130197: Test `pygettext`'s `--version` CLI option (#133022)
Switched to and reset branch 'main'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:3446: clean-retain-profile] Error 1 (ignored)
./Modules/socketmodule.c: In function ‘getsockaddrarg’:
./Modules/socketmodule.c:2646:9: warning: ‘strncpy’ specified bound 64 equals destination size [-Wstringop-truncation]
 2646 |         strncpy((char *)sa->salg_name, name, sizeof(sa->salg_name));
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ar: unable to copy file 'libpython3.16.a'; reason: No space left on device
make[2]: *** [Makefile:1157: libpython3.16.a] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:990: profile-gen-stamp] Error 2
make: *** [Makefile:1002: profile-run-stamp] Error 2

@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable LTO 3.x (tier-3) has failed when building commit d63c994.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1654/builds/2932) and take a look at the build logs.
  4. Check if the failure is related to this commit (d63c994) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1654/builds/2932

Summary of the results of the build (if available):

Click to see traceback logs
Note: switching to 'd63c9940f0bcc5497c42c6ac2768cdab02300e10'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at d63c9940f0bcc gh-130197: Test `pygettext`'s `--version` CLI option (#133022)
Switched to and reset branch 'main'

ar: unable to copy file 'libpython3.16.a'; reason: No space left on device
make: *** [Makefile:1157: libpython3.16.a] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news stale Stale PR or inactive for long period of time. tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants