gh-146261: JIT: protect against function version changes#146300
Merged
Fidget-Spinner merged 7 commits intopython:mainfrom Apr 12, 2026
Merged
gh-146261: JIT: protect against function version changes#146300Fidget-Spinner merged 7 commits intopython:mainfrom
Fidget-Spinner merged 7 commits intopython:mainfrom
Conversation
Fidget-Spinner
requested review from
markshannon,
savannahostrowski and
tomasr8
as code owners
Fidget-Spinner
added
skip news
awaiting core review
and removed
awaiting core review
labels
kumaraditya303
approved these changes
Apr 6, 2026
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Member
Author
|
@markshannon does this bugfix look okay to you? The reason we need this is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the func_version symbol changes by using the fact that we have recorded values and _CHECK_FUNCTION_VERSION guards --- if we simply keep those around and not eliminate them, our function versions are guaranteed to be correct for all following _PUSH_FRAME if we invalidate dependencies properly in the function version changes.
_CHECK_FUNCTION_VERSIONis wrong #146261