gh-118158: Fix missing newline in py_compile CLI error output#149008
Merged
Conversation
sepehr-rs
reviewed
May 12, 2026
sepehr-rs
left a comment
sepehr-rs
left a comment
Contributor
There was a problem hiding this comment.
Can confirm the fix works:
sepehr@debian:~$ ./python -m py_compile test.py
Sorry: IndentationError: unexpected indent (test.py, line 1)
sepehr@debian:~$
sepehr-rs
reviewed
May 12, 2026
Contributor
There was a problem hiding this comment.
I don’t think it’s standard to add Contributed by in the news entry, and I haven’t seen other CPython issues doing that. But I’ve only started contributing here recently, so I could be missing some context.
Contributor
Author
There was a problem hiding this comment.
Thanks. I followed the example in the devguide:
https://devguide.python.org/getting-started/pull-request-lifecycle/#how-to-write-a-news-entry
itamaro
approved these changes
Jun 16, 2026
itamaro
left a comment
itamaro
left a comment
Contributor
There was a problem hiding this comment.
looks good, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix gh-118158.
The old
main()added a trailing newline to error messages (bpo-23811), which was lost when it was refactored to use argparse.The issue is still reproducible on main. Since this was reported about two years ago and there did not appear to be a PR, I went ahead and opened this fix.