[3.13] gh-148441: Avoid integer overflow in Expat's CharacterDataHandler (GH-148904)#149637
Open
miss-islington wants to merge 2 commits into
Open
[3.13] gh-148441: Avoid integer overflow in Expat's CharacterDataHandler (GH-148904)#149637miss-islington wants to merge 2 commits into
miss-islington wants to merge 2 commits into
Conversation
…er (pythonGH-148904) (cherry picked from commit bc1be4f) Co-authored-by: ByteFlow <fakeshadow1337@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This was referenced May 10, 2026
Documentation build overview
453 files changed ·
|
Member
|
cc @picnixz |
Member
|
Ah it was the issue #150397 you found. I don't have much time to check that, but I think we should first revert the commit and check why on your machine it fails. It should not though |
picnixz
reviewed
Jun 10, 2026
| @support.requires_resource('cpu') | ||
| @support.requires_resource('walltime') | ||
| @support.bigmemtest(size=2**31, memuse=4, dry_run=False) | ||
| def test_large_character_data_does_not_crash(self): |
Member
There was a problem hiding this comment.
Suggested change
| def test_large_character_data_does_not_crash(self): | |
| def test_large_character_data_does_not_crash(self, size): |
Member
|
I'm sorry Victor but I really don't have bandwidth during the week, so could you maybe revert the test commit (my bad) please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit bc1be4f)
Co-authored-by: ByteFlow fakeshadow1337@gmail.com
Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com