Skip to content

Docs: Only add profiling-sampling-visualization.{css,js} to files when necessary#151150

Merged
pablogsal merged 1 commit into
python:mainfrom
StanFromIreland:profiling-sampling-visualization
Jun 9, 2026
Merged

Docs: Only add profiling-sampling-visualization.{css,js} to files when necessary#151150
pablogsal merged 1 commit into
python:mainfrom
StanFromIreland:profiling-sampling-visualization

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jun 9, 2026

Copy link
Copy Markdown
Member

Now, I know Tachyon is cool and all, but I don't think we need to advertise it on every page ;-)
We are currently including the JS and CSS on every page of the docs, e.g. the about page:

    <title>About this documentation &#8212; Python 3.16.0a0 documentation</title><meta name="viewport" content="width=device-width, initial-scale=1.0">
[...]
    <link rel="stylesheet" type="text/css" href="_static/profiling-sampling-visualization.css?v=0c2600ae" />
[...]
    <script src="_static/profiling-sampling-visualization.js?v=9811ed04"></script>

CC @lkollar

@StanFromIreland StanFromIreland requested a review from pablogsal June 9, 2026 12:17
@StanFromIreland StanFromIreland added docs Documentation in the Doc dir skip issue labels Jun 9, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jun 9, 2026
lkollar
lkollar reviewed Jun 9, 2026
View reviewed changes

@lkollar lkollar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops 😅LGTM. Thanks for the fix @StanFromIreland!

@pablogsal pablogsal merged commit 0a179e7 into python:main Jun 9, 2026
38 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 9, 2026
@pablogsal pablogsal added awaiting core review needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 9, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 9, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 9, 2026

Copy link
Copy Markdown

GH-151156 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 9, 2026
@StanFromIreland StanFromIreland deleted the profiling-sampling-visualization branch June 9, 2026 13:18
StanFromIreland added a commit that referenced this pull request Jun 9, 2026
@miss-islington @StanFromIreland
[3.15] Docs: Only add profiling-sampling-visualization.{css,js} to …
22d32b6 
…files when necessary (GH-151150)

(cherry picked from commit 0a179e7)

Co-authored-by: Stan Ulbrych <stan@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

1 more reviewer

@lkollar lkollar lkollar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @lkollar @pablogsal