gh-151119: Sync eval stack in LIST_APPEND on allocation failure#151538
Open
bhuvi27 wants to merge 1 commit into
Open
gh-151119: Sync eval stack in LIST_APPEND on allocation failure#151538bhuvi27 wants to merge 1 commit into
bhuvi27 wants to merge 1 commit into
Conversation
Treat _PyList_AppendTakeRef as an escaping call in the cases generator so LIST_APPEND and CALL_LIST_APPEND save the stack pointer before list resize can trigger decref. Add regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LIST_APPENDfails to resize a list under simulated memory pressure (_testcapi.set_nomemory)._PyList_AppendTakeReffromNON_ESCAPING_FUNCTIONSso the cases generator emits stack pointer save/restore around it, same asSET_ADD.test_list_append_nomemory_debugregression test.Fixes #151119