Skip to content

gh-151947: Fix all Sphinx reference warnings in email.{charset,parser}.rst - #152178

Merged
StanFromIreland merged 5 commits into
python:mainfrom
lpyu001:Fix-all-Sphinx-reference-warnings-in-email
Oct 25, 2026
Merged

gh-151947: Fix all Sphinx reference warnings in email.{charset,parser}.rst#152178
StanFromIreland merged 5 commits into
python:mainfrom
lpyu001:Fix-all-Sphinx-reference-warnings-in-email

Conversation

@lpyu001

@lpyu001 lpyu001 commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@lpyu001
lpyu001 requested review from a team, AA-Turner, StanFromIreland and hugovk as code owners June 25, 2026 09:27
@bedevere-app bedevere-app Bot mentioned this pull request Jun 25, 2026
Closed
@lpyu001 lpyu001 changed the title gh-151947: Fix all Sphinx reference warnings in Doc/library/email.{charset,parse… gh-151947: Fix all Sphinx reference warnings in email.{charset,parser}.rst Jun 25, 2026
@read-the-docs-community

read-the-docs-community Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35394643 | 📁 Comparing 66eebca against main (6f9c76d)

  🔍 Preview build  

437 files changed · + 13 added · ± 423 modified · - 1 deleted

+ Added

± Modified

- Deleted

@StanFromIreland StanFromIreland mentioned this pull request Jun 25, 2026
Closed
StanFromIreland
StanFromIreland approved these changes Jun 25, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitdancer, can you take a glance please when you have a chance?

@StanFromIreland StanFromIreland changed the title gh-151947: Fix all Sphinx reference warnings in email.{charset,parser}.rst gh-151947: Fix all Sphinx reference warnings in email.{charset,parser}.rst Jun 25, 2026
@StanFromIreland

StanFromIreland commented Jun 25, 2026

Copy link
Copy Markdown
Member

Ha, the tests pass on this PR. That one really was cursed.

@lpyu001

lpyu001 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

It has been in a merge-ready state for over a month. Could it be merged? @StanFromIreland

@StanFromIreland

StanFromIreland commented Aug 14, 2026

Copy link
Copy Markdown
Member

It has been in a merge-ready state for over a month.

There are conflicts. Additionally I'd still like to get one of the email expert's reviews (CC @bitdancer @serhiy-storchaka)

StanFromIreland
StanFromIreland reviewed Aug 14, 2026
View reviewed changes
Comment thread Doc/tools/.nitignore Outdated
lpyu001 and others added 3 commits August 14, 2026 16:44
@lpyu001
Update
671ef57 
Removed email.charset.rst and email.parser.rst from .nitignore
@lpyu001
Update .nitignore
0a10ff8 
Removed http.cookiejar.rst and http.server.rst from .nitignore
@StanFromIreland
Merge branch 'main' into Fix-all-Sphinx-reference-warnings-in-email
66eebca
@StanFromIreland
StanFromIreland enabled auto-merge (squash) October 25, 2026 17:20
@StanFromIreland
StanFromIreland merged commit efbd165 into python:main Oct 25, 2026
56 checks passed
@StanFromIreland StanFromIreland added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 25, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

Thanks @lpyu001 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

GH-160671 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 25, 2026
@bedevere-app

bedevere-app Bot commented Oct 25, 2026

Copy link
Copy Markdown

GH-160672 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 25, 2026
StanFromIreland added a commit that referenced this pull request Oct 25, 2026
@miss-islington @lpyu001 @StanFromIreland
[3.14] gh-151947: Fix all Sphinx reference warnings in `email.{charse…
d612e0d 
…t,parser}.rst` (GH-152178) (#160671)

(cherry picked from commit efbd165)

Co-authored-by: Pengyu Lee <lipengyu@kylinos.cn>
Co-authored-by: Stan Ulbrych <stan@python.org>
StanFromIreland added a commit that referenced this pull request Oct 25, 2026
@miss-islington @lpyu001 @StanFromIreland
[3.15] gh-151947: Fix all Sphinx reference warnings in `email.{charse…
99417e5 
…t,parser}.rst` (GH-152178) (#160672)

(cherry picked from commit efbd165)

Co-authored-by: Pengyu Lee <lipengyu@kylinos.cn>
Co-authored-by: Stan Ulbrych <stan@python.org>
@lpyu001
lpyu001 deleted the Fix-all-Sphinx-reference-warnings-in-email branch October 25, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lpyu001 @StanFromIreland