gh-154667: Validate zipfile timestamps consistently#154740
Open
Taeknology wants to merge 1 commit into
Open
Conversation
Signed-off-by: Taeknology <20297177+Taeknology@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154667.
ZipInfonow consistently rejects timestamps after 2107. Whenstrict_timestampsis false,ZipInfo.from_file()clamps filesystemtimestamps outside the supported range.
The upper limit is
2107-12-31 23:59:58to account for the ZIP format'stwo-second timestamp resolution.
Tests cover timestamp validation, clamping, local time conversion failures,
and ZIP round-tripping.
The targeted tests, full
test_zipfilesuite, reference leak checks, andlocally available CI checks pass.
zipfile: Inconsistent and insufficient date_time validation and handling acrossZipInfomethods #154667