gh-154561: Check module dict after trying to load submodule#154742
Open
johnslavik wants to merge 2 commits into
Open
gh-154561: Check module dict after trying to load submodule#154742johnslavik wants to merge 2 commits into
johnslavik wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locally I bumped the test to use 100 threads for higher failure reproducibility:
I cannot reproduce failures after the proposed change: after trying to load the submodule, we re-check the module dict in case a different thread beat us to it, in which case the attribute can be returned directly.
test_concurrent_lazy_import_reificationis flaky #154561