gh-154744: Improve detection of skipinitialspace in csv.Sniffer#154745
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-154744: Improve detection of skipinitialspace in csv.Sniffer#154745serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Detect the padding by parsing the sample both with and without skipinitialspace and comparing the two readings, instead of testing whether every field following a delimiter starts with a space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skipinitialspaceis now detected by parsing the sample both with and without it and comparing the two readings, instead of testing whether every field which follows a delimiter starts with a space.a, b, c).Measured on the 560 files of the CSVsniffer corpora,
skipinitialspacechanges the number of fields in 7 of them, and in 3 of those the correct reading collapses the rows to a single width.