gh-157157: Make test_taskgroup_cancel_keeps_outer_cancellation deterministic - #157158
Open
iamsharduld wants to merge 2 commits into
Open
gh-157157: Make test_taskgroup_cancel_keeps_outer_cancellation deterministic#157158iamsharduld wants to merge 2 commits into
iamsharduld wants to merge 2 commits into
Conversation
…deterministic The test cancelled the parent task from outside after a 10 ms sleep, expecting the group to still be waiting for its child. If the event loop stalled for longer than that before the body task first ran, the outer cancel() landed while the parent's awaited future was already cancelled by the group, and its message was dropped, failing the test on slow builds such as the TSan CI job. Synchronize on events instead: the child signals from its finally block that the group is cancelling and waits to be released, and only then is the parent task cancelled from outside.
iamsharduld
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
September 8, 2026 04:17
| @@ -0,0 +1,2 @@ | |||
| Fix a timing dependence in ``test_taskgroup_cancel_keeps_outer_cancellation`` | |||
Contributor
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! : please review the changes made to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the timing dependence described in the issue: the test cancelled the parent task from outside after
await asyncio.sleep(0.01), and lost the cancellation message whenever the loop stalled for more than 10 ms before the body task first ran (the mechanism, and a reproducer that stalls the loop withtime.sleep(), are in the issue).The test now synchronizes on two events instead of sleeping. The child signals from its
finallyblock that the group is cancelling, which by then has cancelled the parent task and is waiting for the child, and waits there until the test releases it. Only then does the test cancel the parent task from outside. The ordering is fixed by the callback queue, not by time, so it holds on any build speed and for both task implementations.Checked:
TestTaskGroupandTestEagerTaskTaskGroup, 10 of 10 repeated runs, and the wholetest_asyncio.test_taskgroupsmodule passes.asyncio.TaskGroupswallows cancellations coming from outside of it #155433 fix reverted locally, the rewritten test still fails in both classes (CancelledError not raised), so it keeps guarding the bug it was written for.Since the original test was added by the gh-155433 fix, this likely wants the same backports.