Skip to content

Skip optimisations to speedup test_freeze rebuild #157264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hugovk wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Draft

Skip optimisations to speedup test_freeze rebuild #157264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Tools/freeze/test/freeze.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,16 @@ def find_opt(args, name):
return -1


def remove_opt(args: list[str], name: str) -> None:
opt = f'--{name}'
optstart = f'{opt}='
args[:] = [
arg
for arg in args
if arg != opt and not arg.startswith(optstart)
]


def ensure_opt(args, name, value):
opt = f'--{name}'
pos = find_opt(args, name)
Expand Down Expand Up @@ -128,6 +138,10 @@ def prepare(script=None, outdir=None):
# Run configure.
print(f'configuring python in {builddir}...')
config_args = shlex.split(sysconfig.get_config_var('CONFIG_ARGS') or '')
# Optimisations such as LTO and PGO only slow down the build of this
# throwaway interpreter without affecting what the test checks.
remove_opt(config_args, 'enable-optimizations')
remove_opt(config_args, 'with-lto')
cmd = [os.path.join(srcdir, 'configure'), *config_args]
ensure_opt(cmd, 'cache-file', os.path.join(outdir, 'python-config.cache'))
prefix = os.path.join(outdir, 'python-installation')
Expand Down
Loading