Repository navigation
gh-160027: Use urlsplit() instead of urlparse() in http.cookiejar.request_host() - #160680
Open
eendebakpt wants to merge 1 commit into
Open
eendebakpt wants to merge 1 commit into
eendebakpt wants to merge 1 commit into
Conversation
request_host() only needs the netloc, which is the same for both, and urlsplit() is cached while urlparse() is not. It is called once for every stored domain on each CookieJar.add_cookie_header() call, which is now about 2.5x faster. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
bedevere-app
Bot
added
awaiting core review
type-feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request_host()only needs thenetloc, which is the same forurlsplitandurlparse. urlsplit() is cached while urlparse() is not and faster.Benchmarks:
(benchmark script from the corresponding issue)
With this change the code is still linear in the number of stored domains.