Repository navigation
Conversation
|
All commit authors signed the Contributor License Agreement. |
eendebakpt
reviewed
Oct 26, 2026
Contributor
|
@serhiy-storchaka @gpshead Could you have look at the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For pure ASCII input, we can skip the regex/generator path in
unquote()and decode the result of_unquote_impl()directly. The regex would match the whole string as a single chunk anyway, so the result is identical.Benchmarks are in the issue but up to 2x faster in the micro-benchmark for the common short ascii input.
Added a test checking that the fast path and the general path decode escapes the same way.
Resolves #160690