Repository navigation
Conversation
2 of 8 tasks
Member
Author
|
Hi @chris-eibl can you help review this? |
chris-eibl
approved these changes
Oct 28, 2026
chris-eibl
left a comment
chris-eibl
left a comment
Member
There was a problem hiding this comment.
Thanks @aisk. This LGTM. I've also done a quick local run.
To me, these three new funcs in _winapi make sense without any _pyrepl_ prefix or comment (#150582 (comment)), but I'd appreciate @zooba's sentiment.
Member
Author
Sorry I just missed @zooba's comment on the original issue. And I agree with @chris-eibl because at least these three functions are generic enough to not need a prefix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_pyrepl#150582