Skip to content

gh-96894: Do not turn echo off for subsequent commands in batch activators#96895

Merged
zooba merged 3 commits intopython:mainfrom
pawelszramowski:no_echo_off
Apr 13, 2026
Merged

gh-96894: Do not turn echo off for subsequent commands in batch activators#96895
zooba merged 3 commits intopython:mainfrom
pawelszramowski:no_echo_off

Conversation

@pawelszramowski
Copy link
Copy Markdown
Contributor

@pawelszramowski pawelszramowski commented Sep 17, 2022

Some @ are certainly unnecessary but I don't feel confident enough to optimize.

Closes #96894

@ghost
Copy link
Copy Markdown

ghost commented Sep 17, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@vsajip
Copy link
Copy Markdown
Member

vsajip commented Sep 18, 2022

This seems a bit brittle (e.g. if new lines are added) - can't the echo be turned off and then back on at exit points, rather than almost every line being changed?

@pawelszramowski
Copy link
Copy Markdown
Contributor Author

Unfortunately, there's no reasonable way to restore the caller's setting when you're done (yeah, batch is crap):

@pawelszramowski
Copy link
Copy Markdown
Contributor Author

@vsajip ping :)

@arhadthedev
Copy link
Copy Markdown
Member

@python/windows-team

@pawelszramowski
Copy link
Copy Markdown
Contributor Author

@vsajip ping again! Please approve, assign a different reviewer, or let me know what you would like me to change.

Copy link
Copy Markdown
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Leaving for @vsajip to merge/object

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot bot commented Apr 18, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 11, 2026
@zooba zooba requested a review from FFY00 as a code owner April 13, 2026 11:21
@zooba zooba enabled auto-merge (squash) April 13, 2026 11:21
@zooba
Copy link
Copy Markdown
Member

zooba commented Apr 13, 2026

Better late than never.

@zooba zooba merged commit d24ce17 into python:main Apr 13, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS-windows stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch activators unexpectedly turn echo off for subsequent commands

5 participants