Skip to content

Revert normalize() performance changes (gh-143658) #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaraco wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −8
Open

Revert normalize() performance changes (gh-143658) #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions importlib_metadata/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,15 +962,8 @@ def __init__(self, name: str | None):
def normalize(name):
"""
PEP 503 normalization plus dashes as underscores.

Specifically avoids ``re.sub`` as prescribed for performance
benefits (see python/cpython#143658).
"""
value = name.lower().replace("-", "_").replace(".", "_")
# Condense repeats
while "__" in value:
value = value.replace("__", "_")
return value
return re.sub(r"[-_.]+", "-", name).lower().replace('-', '_')

@staticmethod
def legacy_normalize(name):
Expand Down
Loading