Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mypy/typeanal.py
Original file line number Diff line number Diff line change
Expand Up @@ -1199,6 +1199,15 @@ def visit_callable_type(
"Arguments not allowed after ParamSpec.args", t, code=codes.VALID_TYPE
)
at = self.anal_type(ut, nested=nested, allow_unpack=False)
if isinstance(at, Parameters):
# A Parameters here comes from a misplaced Concatenate ending in
# an explicit ellipsis, e.g. Callable[[Concatenate[int, ...]], None].
self.fail(
"Concatenate is only valid as the first argument to Callable",
ut,
code=codes.VALID_TYPE,
)
at = AnyType(TypeOfAny.from_error)
arg_types.append(at)

if nested and arg_types:
Expand Down
13 changes: 13 additions & 0 deletions test-data/unit/check-parameter-specification.test
Original file line number Diff line number Diff line change
Expand Up @@ -2755,3 +2755,16 @@ reveal_type(Sneaky(f8, 1, y='').kwargs) # N: Revealed type is "builtins.dict[bu
reveal_type(Sneaky(f9, 1, y=0).kwargs) # N: Revealed type is "TypedDict('builtins.dict', {'x'?: builtins.int, 'y': builtins.int, 'z'?: builtins.str})"
reveal_type(Sneaky(f9, 1, y=0, z='').kwargs) # N: Revealed type is "TypedDict('builtins.dict', {'x'?: builtins.int, 'y': builtins.int, 'z'?: builtins.str})"
[builtins fixtures/paramspec.pyi]

[case testParamSpecNoCrashOnConcatenateInCallableArg]
from typing import Callable
from typing_extensions import Concatenate, ParamSpec

P = ParamSpec("P")

def takes_paramspec(f: Callable[P, object]) -> bool:
return False

def run(callback: Callable[[Concatenate[int, ...]], None]) -> None: # E: Concatenate is only valid as the first argument to Callable
takes_paramspec(callback)
[builtins fixtures/paramspec.pyi]
Loading