Skip to content

[minor] Clean up optional in type map return type #22254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 1 commit into from
Oct 21, 2026
Merged

[minor] Clean up optional in type map return type #22254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/checker_shared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ def narrow_type_by_identity_equality(
operand_types: list[Type],
expr_indices: list[int],
narrowable_indices: AbstractSet[int],
) -> tuple[dict[Expression, Type] | None, dict[Expression, Type] | None]:
) -> tuple[dict[Expression, Type], dict[Expression, Type]]:
raise NotImplementedError

@abstractmethod
Expand Down
4 changes: 2 additions & 2 deletions mypy/checkpattern.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ def visit_value_pattern(self, o: ValuePattern) -> PatternType:
ok_map, rest_map = self.chk.narrow_type_by_identity_equality(
"==", [node, TempNode(typ)], [current_type, typ], [0, 1], {0}
)
ok_type = ok_map.get(node, current_type) if ok_map is not None else UninhabitedType()
rest_type = rest_map.get(node, current_type) if rest_map is not None else UninhabitedType()
ok_type = ok_map.get(node, current_type)
rest_type = rest_map.get(node, current_type)
return PatternType(ok_type, rest_type, {})

def visit_singleton_pattern(self, o: SingletonPattern) -> PatternType:
Expand Down
Loading